Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo standardization, using GH actions #101

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Repo standardization, using GH actions #101

merged 2 commits into from
Apr 30, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 30, 2021

Enforcing minimum node version of 12
Removing circleci config, adding GH actions

Related: https://github.com/MetaMask/MetaMask-planning/issues/32

@ryanml ryanml self-assigned this Apr 30, 2021
@ryanml ryanml requested a review from a team as a code owner April 30, 2021 06:19
Enforcing minimum node version of 12

Removing circleci config, adding GH actions
runs-on: ubuntu-20.04
strategy:
matrix:
node-version: [12.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 12.x here? Not 14 and 16 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@rekmarks rekmarks merged commit a20162c into main Apr 30, 2021
@rekmarks rekmarks deleted the repo-standard branch April 30, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants